Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to keep the color scheme in CLI? #6

Closed
sneko opened this issue Jun 8, 2022 · 6 comments · Fixed by #8
Closed

How to keep the color scheme in CLI? #6

sneko opened this issue Jun 8, 2022 · 6 comments · Fixed by #8
Assignees
Labels
bug Something isn't working

Comments

@sneko
Copy link

sneko commented Jun 8, 2022

Hi,

By default all my hexas will become "hsl" whereas I want to keep my old behavior (coming from json-sass ;) ). I did not succeed in using something like:

json2scss-map --colorConversion false -i ./src/styles/xxxxx.json -o ./src/styles/xxxxxx.scss

or

json2scss-map --convertTo 'hex' false -i ./src/styles/xxxxx.json -o ./src/styles/xxxxxx.scss

(I tried --convertTo 'hex' --convertTo hex --convertTo HEX)

Do you know if that's possible?

Thank you,

@susanta96
Copy link

Okay. I don't think I have updated the CLI commands, however , there might be easy fix. I will let you know .

@susanta96
Copy link

Or I would update the package to support CLI properly

@susanta96 susanta96 added the bug Something isn't working label Mar 22, 2023
@susanta96 susanta96 self-assigned this Jun 3, 2023
@ThatGuyCND
Copy link

I really wanted to use this for my project as a CLI tool — very open to feedback on my linked MR.

@susanta96
Copy link

susanta96 commented Apr 20, 2024

Its awesome that you went through this to fix it. I will definitely check on your PR. If, everything is working perfectly, i would be happy to merge your PR, will create a new release. Give me 3 to 4 days.

susanta96 added a commit that referenced this issue Apr 24, 2024
@ThatGuyCND
Copy link

ThatGuyCND commented May 2, 2024

@susanta96 do you know when you might tag a new release version that includes this update?

@susanta96
Copy link

Hi @ThatGuyCND sorry for the delay. By tomorrow I will release a new version on NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants