Changes needed to allow for use of IFSAR DEM #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jlrine2
reviewed
Nov 19, 2020
|
|
||
| files = [] | ||
| fileList = False | ||
| lines = [line.rstrip('\n') for line in open(configFile)] |
There was a problem hiding this comment.
This leaves the file open to be garbage collected instead of explicitly closing.
Jlrine2
reviewed
Nov 19, 2020
Comment on lines
+71
to
+75
| for ii in range(len(lines)): | ||
| if fileList == True: | ||
| files.append(lines[ii]) | ||
| if section in lines[ii]: | ||
| fileList = True |
There was a problem hiding this comment.
could use for line in lines
|
closing this as stale; will re-open when we actively work on IFSAR support and otherwise will track it in ASFHyP3/hyp3-gamma#183 and #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.