Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake in default template to improve PackageCompiler support #53

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Jun 30, 2024

This fixes #15 and is an alternative to #49.

The default template "no-slides.pptx" is less than 35 kB. This PR reads it into a constant at precompile time.
This PR allows passing a Vector{UInt8} of pre-read template data in the template_path argument to write.

The main advantage of this over #49 is that it is easier to edit the default template and there is no need to find someplace to store the artifact.

I also added a .gitattributes file to prevent GitHub Windows CI from changing the file endings: https://code.visualstudio.com/docs/devcontainers/tips-and-tricks#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files This is to ensure the baked in data is the same bytes on all systems.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (09e8a06) to head (ec90d2c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   96.00%   95.85%   -0.16%     
==========================================
  Files           9       10       +1     
  Lines         476      507      +31     
==========================================
+ Hits          457      486      +29     
- Misses         19       21       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/write.jl Outdated Show resolved Hide resolved
@matthijscox-asml matthijscox-asml merged commit 100de63 into ASML-Labs:main Jul 8, 2024
5 checks passed
@nhz2 nhz2 deleted the bake-in-templates branch July 8, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow package best practices
2 participants