add a new graph cached attribute to the Bot object
#792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... it holds a networkx graph representation of the maze. The graph was before manually generated using the walls_to_graph function in utils.py
otizonaizit
added a commit
to ASPP/pelita_template
that referenced
this pull request
May 15, 2024
|
Should we have a deprecated decorator on Should we use the frozen graph then? It doesn’t help much but at least it signals ‘do not touch’. |
|
Not sure it makes sense to have the deprecated decorator. New code will not use the old function. Old code is not going to be updated by anyone, so the deprecation won't motivate anyone to update the code. In my opinion we can leave the import there for an indefinite time.
Before merging I want to add some tests to be sure that if a bot changes the graph right now those changes are indeed lost. I am not sure given the way the caching is implemented. Sorry, I didn't think of it when I submitted the PR, otherwise I would have put the WIP label...
We can then use the frozen decorator then, which should pass the still-to-be-written tests, in case the current implementation is indeed broken.
…On Wed 15 May, 07:08 +0000, Rike-Benjamin Schuppner ***@***.***> wrote:
Should we have a deprecated decorator on `utils.walls_to_graph`? At some point we should surely decide on one import only.
Should we use the frozen graph then? It doesn’t help much but at least it signals ‘do not touch’.
—
Reply to this email directly, view it on GitHub¹, or unsubscribe².
You are receiving this because you authored the thread.☘Message ID: ***@***.***>
––––
¹ #792 (comment)
² https://github.com/notifications/unsubscribe-auth/AACUYC4UBHUZJYSAE2XWV2TZCNT6VAVCNFSM6AAAAABHX4IJ5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGY2TGNRYHE
|
|
Ok but if we keep the import around then we should still flag it so that is is not removed by some import checker. Or remove it now and live with the consequences. |
|
The graph is now a read-only view and tests have been added. Ready to merge on my side. |
otizonaizit
force-pushed
the
feature/graph-attribute
branch
from
e1dfc56
to
440e72a
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
add a new `graph` cached attribute to the `Bot` object 0c9a0f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new cached attribute
graphto theBotobject.This PR also moves the
walls_to_graphfunction fromutils.pytoteam.py, where it arguably now belongs. An aliaswalls_to_graphis left inutils.pyfor backward compatibility.Fixes: #789