Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/elections tests #178

Merged
merged 19 commits into from
May 31, 2020
Merged

Feature/elections tests #178

merged 19 commits into from
May 31, 2020

Conversation

kadensu
Copy link
Contributor

@kadensu kadensu commented May 18, 2020

Partially completes election testing #177.

  • Renamed "subtest" files to "utils"

  • Added and restructured util functions for better reusability

  • Moved data objects to data files

  • GET test for /elections/vote/(.*)

  • PUT test for /elections/vote/(.*)

  • DELETE test for /elections/vote/(.*)

  • GET test for /elections/election/(.*)/count

  • DELETE test for /elections/election/(.)/candidate/(.)

  • POST test for /elections/election/(.*)/ballot

  • GET test for /election/{election_id}/ballot

  • GET test for /election/{election_id}/ballot/{vote_id}

  • DELETE test for /election/{election_id}/ballot/{vote_id}

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #178 into develop will increase coverage by 4.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #178      +/-   ##
===========================================
+ Coverage    48.35%   52.40%   +4.05%     
===========================================
  Files           29       29              
  Lines         3032     3032              
===========================================
+ Hits          1466     1589     +123     
+ Misses        1566     1443     -123     
Impacted Files Coverage Δ
src/aswwu/base_handlers.py 81.04% <0.00%> (+1.30%) ⬆️
src/aswwu/exceptions.py 78.26% <0.00%> (+4.34%) ⬆️
src/aswwu/models/elections.py 97.56% <0.00%> (+4.87%) ⬆️
src/aswwu/alchemy_new/elections.py 70.62% <0.00%> (+8.75%) ⬆️
src/aswwu/validators/elections.py 64.00% <0.00%> (+9.33%) ⬆️
src/aswwu/route_handlers/elections.py 91.34% <0.00%> (+28.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c93cec...9abd617. Read the comment docs.

@kadensu kadensu merged commit 0848392 into develop May 31, 2020
@atg7000 atg7000 deleted the feature/elections-tests branch April 5, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant