Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly build's occasional failure #68

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

ma-sadeghi
Copy link
Collaborator

@ma-sadeghi ma-sadeghi commented Jan 30, 2024

The circuit fitter (based on impedance.py) occasionally fails (because of bad initial guess). This PR implements iters as argument so the fitter can be called repeated to avoid divergence.

@ma-sadeghi ma-sadeghi added enhancement New feature or request maintenance Package maintenance labels Jan 30, 2024
@ma-sadeghi ma-sadeghi merged commit d6f155f into develop Jan 30, 2024
4 checks passed
@ma-sadeghi ma-sadeghi deleted the test/loosen-fitter-tol branch January 30, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Package maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant