Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow memory leak #31

Open
Mark2000 opened this issue Aug 11, 2023 · 4 comments
Open

Slow memory leak #31

Mark2000 opened this issue Aug 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Mark2000
Copy link
Contributor

Describe the bug
The general environment slowly leaks memory.

To Reproduce
Steps to reproduce the behavior:

  1. Train the general environment with rllib. After ~5 million steps over 30 cores, the memory usage has increased from about 30% to 100% of 3.8gb/core.

Expected behavior
No leaks.

Version (please complete the following information):

  • Python: 3.10
  • Basilisk: 2.2.1a?
  • Plaform: CURC cluster
@Mark2000 Mark2000 added the bug Something isn't working label Aug 11, 2023
@Mark2000 Mark2000 self-assigned this Aug 11, 2023
@Mark2000 Mark2000 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Sep 19, 2023
@Mark2000 Mark2000 removed their assignment Sep 19, 2023
@Mark2000
Copy link
Contributor Author

It appears that this issue is related to ray/rllib and not the environment. At some point, a job should be submitted to CURC that repeatedly resets and steps through the environment without any training code while monitoring memory usage to confirm the environment is not leaking.

@Mark2000
Copy link
Contributor Author

image
Still seeing a memory leak just by repeatedly stepping through and resetting env, no training.

@Mark2000
Copy link
Contributor Author

Using objgraph, a major source of leakiness is reading from bsk loggers/messages. Appears to allocate new vectors for every read that do not get deleted?

@Mark2000 Mark2000 self-assigned this Oct 18, 2023
@Mark2000
Copy link
Contributor Author

Mark2000 commented Dec 5, 2023

Switching to #86 may address some memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant