Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to load command #242

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Add validation to load command #242

merged 2 commits into from
Nov 9, 2019

Conversation

BillChee123
Copy link

No description provided.

Copy link

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the change. Mind elaborate?

@@ -31,6 +31,8 @@
+ PREFIX_FILEPATH + "C:/Users/username/Downloads/ ";
public static final String MESSAGE_SUCCESS = "Memes loaded successfully to the import staging area.";
public static final String MESSAGE_LOAD_FAILURE = "Invalid directory path given.";
public static final String MESSAGE_LOAD_NON_EMPTY_TAB_FAILURE = "There are memes present in the import tab. "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't do load twice because exception is not handled. I just want to handle the exception.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using UniqueMemeList for importlist. Loading twice from same directory will result in duplicate memes

Copy link

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am fine with this.

Copy link

@moziliar moziliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillChee123 BillChee123 merged commit c9530fa into master Nov 9, 2019
@BillChee123 BillChee123 deleted the bill/test branch November 9, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants