Pull from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feedback from previous students indicated that they have some problem grokking the code base. Let's address this by having a simple tutorial where students learn how to apply the tools at hand to trace the execution flow of code.
Add tutorial on tracing code
Address a regression in ebbb713 where subsequent `help` commands will spawn a `HelpWindow` maximized, covering the screen. Disable the resizability and the maximize button completely as it serves no purpose. Remove unnecessary call to sizeToScene() as HelpWindow defaults to USE_COMPUTED_SIZE and the computed size of all its children nodes are available before it is shown. Remove TODO in HelpWindow.fxml as the initial size is set to computed size.
Prevent HelpWindow from maximizing
In lieu of a tutorial on how to morph which can be hard to write and maintain, we provide a simpler and shorter tutorial on how to remove a field instead. Students trying to morph the product can repeat this tutorial to get the model to a state where they can work with.
Add tutorial on how to remove a field
Since we removed the tutorial for RemarkCommand from AB-4's developer guide, let's add a new tutorial for it at the AB-3.5 level.
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.