Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export 1.3 #151

Merged
merged 17 commits into from Oct 30, 2019
Merged

Export 1.3 #151

merged 17 commits into from Oct 30, 2019

Conversation

LeowWB
Copy link
Collaborator

@LeowWB LeowWB commented Oct 29, 2019 •
edited

Fixes #54

@LeowWB
Fix LeowWB author tag in dg
2a59330
@LeowWB
Add additional design consideration to DG
a20031e
@LeowWB
Add some boundary test cases for export support classes
a27f37a
@LeowWB
Refactor ExportUtil into model.export package
23abd93
@LeowWB
Create ExportPath abstract class
eacc5b2
@LeowWB
Create JsonExportFilePath and JsonExportPath
b340da4
@LeowWB
Create new export method in ExportPath
9ed2de1
@LeowWB
Rename class and variable for better clarity
1650afe
@LeowWB
Refactor code such that exporting of document now goes through
60c95fb 
DocumentPath
@LeowWB
Create ExportPathFactory
254f304
@LeowWB
Refactor existing code to use ExportPath abstraction rather than
21d5dc8 
DocumentPath
@LeowWB
Modify a comment for accuracy
1627ab3
@LeowWB
Modify JsonExportPath to depend on JsonExportUtil class (not created
d2406e5 
yet)
@LeowWB
Create JsonExportUtil.java
32f2103
@LeowWB
Fix linting
5a5ad75
@LeowWB
Remove a stray conflict marker
ee3e68a
dalsontws
dalsontws reviewed Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@dalsontws dalsontws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/main/java/seedu/address/model/export/DocumentFilePath.java Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
@LeowWB LeowWB merged commit 9906a79 into AY1920S1-CS2103T-T12-4:master Oct 30, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 30, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keiteo keiteo keiteo left review comments

@dalsontws dalsontws dalsontws left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability for export command to infer format based on given extension
3 participants
@LeowWB @keiteo @dalsontws