Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2113-T14-1]-gowgos5-A-Travis #5

Merged
merged 4 commits into from
Sep 16, 2019
Merged

[CS2113-T14-1]-gowgos5-A-Travis #5

merged 4 commits into from
Sep 16, 2019

Conversation

gowgos5
Copy link

@gowgos5 gowgos5 commented Sep 16, 2019

Completed

  • Refactor code to meet checkstyle requirements.
  • Add Travis CI for Continuous Integration.

@gowgos5 gowgos5 requested a review from aquohn September 16, 2019 14:02
aquohn
aquohn approved these changes Sep 16, 2019
View reviewed changes
Copy link

@aquohn aquohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, everyone take note that enums are now named like other classes (PascalCase, no longer SCREAMING_SNAKE).

@aquohn aquohn merged commit 2b2bcd2 into AY1920S1-CS2113-T14-1:master Sep 16, 2019
@gowgos5 gowgos5 deleted the branch-checkstyle branch September 16, 2019 14:09
@gowgos5 gowgos5 added this to the v1.1 milestone Oct 2, 2019
@nus-pe-script nus-pe-script mentioned this pull request Oct 2, 2019
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquohn aquohn aquohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gowgos5 @aquohn