Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v.1.4.1] Add, Edit and Delete Description #230

Merged

Conversation

Jargonx
Copy link

@Jargonx Jargonx commented Nov 4, 2020

closes #202

@Jargonx Jargonx added type.Bug A bug priority.High Must do severity.High A flaw that affects most users and causes major problems for users. labels Nov 4, 2020
@Jargonx Jargonx added this to the v1.4 milestone Nov 4, 2020
@Jargonx Jargonx self-assigned this Nov 4, 2020
@Jargonx Jargonx changed the title Add, Edit and Delete Description [v.1.4.1] Add, Edit and Delete Description Nov 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #230 into master will increase coverage by 0.60%.
The diff coverage is 86.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     62.07%   62.68%   +0.60%     
- Complexity      775      802      +27     
============================================
  Files           141      144       +3     
  Lines          3043     3119      +76     
  Branches        428      440      +12     
============================================
+ Hits           1889     1955      +66     
- Misses          972      973       +1     
- Partials        182      191       +9     
Impacted Files Coverage Δ Complexity Δ
...ivot/logic/parser/AddDescriptionCommandParser.java 72.72% <ø> (ø) 3.00 <0.00> (ø)
...va/seedu/pivot/logic/parser/EditCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...vot/logic/parser/EditDescriptionCommandParser.java 72.72% <72.72%> (ø) 3.00 <3.00> (?)
.../descriptioncommands/DeleteDescriptionCommand.java 85.71% <85.71%> (ø) 8.00 <8.00> (?)
...ds/descriptioncommands/EditDescriptionCommand.java 87.87% <87.87%> (ø) 10.00 <10.00> (?)
...nds/descriptioncommands/AddDescriptionCommand.java 86.66% <100.00%> (ø) 9.00 <0.00> (?)
.../seedu/pivot/logic/parser/DeleteCommandParser.java 81.25% <100.00%> (+1.25%) 13.00 <0.00> (+1.00)
...main/java/seedu/pivot/logic/parser/ParserUtil.java 69.62% <100.00%> (+2.53%) 20.00 <0.00> (+1.00)
...edu/pivot/model/investigationcase/Description.java 100.00% <100.00%> (ø) 10.00 <5.00> (+4.00)
...main/java/seedu/pivot/storage/JsonAdaptedCase.java 94.56% <100.00%> (-0.18%) 13.00 <0.00> (-1.00)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044de4b...fe5f820. Read the comment docs.

@Vielheim Vielheim merged commit 554f9ff into AY2021S1-CS2103-F09-2:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do severity.High A flaw that affects most users and causes major problems for users. type.Bug A bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Delete description
3 participants