Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dry run bugs #317

Merged
merged 12 commits into from
Oct 31, 2020
Merged

Conversation

qwoprocks
Copy link
Member

@qwoprocks qwoprocks commented Oct 31, 2020

Description

Fixes #279, fixes #290, fixes #299, fixes #301, fixes #303, fixes #305, fixes #306, fixes #313

Testing

Ran tests, all pass. Tried the bugs stated also, seems alright

Remarks

For #301 and #303, the full name/addresses are only viewable in the display panel, will create a new issue to add this info into the UG

I also made the list and suggest commands clear the current viewed client in the display panel

@qwoprocks qwoprocks added type.Bug A bug priority.High Must do severity.High A flaw that affects most users and causes major problems for users. Renders it almost unusable. labels Oct 31, 2020
@qwoprocks qwoprocks added this to the v1.4 milestone Oct 31, 2020
@qwoprocks qwoprocks self-assigned this Oct 31, 2020
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #317 into master will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #317      +/-   ##
============================================
- Coverage     87.14%   87.12%   -0.02%     
- Complexity      930      933       +3     
============================================
  Files           112      112              
  Lines          2427     2455      +28     
  Branches        279      283       +4     
============================================
+ Hits           2115     2139      +24     
- Misses          233      235       +2     
- Partials         79       81       +2     
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...address/logic/commands/CountryNoteEditCommand.java 40.54% <0.00%> (ø) 7.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 89.28% <ø> (ø) 8.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 57.33% <0.00%> (-0.21%) 11.00 <0.00> (+1.00) ⬇️
src/main/java/seedu/address/ui/WidgetViewBox.java 72.72% <88.57%> (+6.06%) 10.00 <6.00> (-2.00) ⬆️
...eedu/address/logic/commands/ClientViewCommand.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 100.00% <100.00%> (ø) 19.00 <5.00> (+2.00)
...dress/logic/commands/CountryNoteDeleteCommand.java 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...address/logic/commands/CountryNoteViewCommand.java 100.00% <100.00%> (ø) 11.00 <0.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d72b4e...8f6a7d7. Read the comment docs.

Copy link
Member

@LeeEnHao LeeEnHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GUI works as expected and the test passes as well! LGTM once you're done with the tweaks

Copy link
Member

@rtshkmr rtshkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggestions aldy implemented based on Telegram chats 👍

checked mainly from the GUI and gave the code a cursory look. everything based on issues work, couldn't break anything so looks good

@qwoprocks qwoprocks merged commit 390b5ef into AY2021S1-CS2103T-F11-4:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do severity.High A flaw that affects most users and causes major problems for users. Renders it almost unusable. type.Bug A bug
Projects
None yet
3 participants