Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement calendar #135

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Implement calendar #135

merged 4 commits into from
Oct 28, 2020

Conversation

yanbingtao
Copy link

@yanbingtao yanbingtao commented Oct 27, 2020 •
edited by ureshiiYing
Loading

Now, a working calendar GUI can be displayed in the calendar pane.

@yanbingtao yanbingtao added type.Story A user story priority.High Must do labels Oct 27, 2020
@yanbingtao yanbingtao added this to the v1.3 milestone Oct 27, 2020
@yanbingtao yanbingtao self-assigned this Oct 27, 2020
@codecov-io
Copy link

codecov-io commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #135 into master will decrease coverage by 3.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
- Coverage     62.17%   59.13%   -3.05%     
  Complexity      601      601              
============================================
  Files           111      112       +1     
  Lines          2176     2288     +112     
  Branches        262      270       +8     
============================================
  Hits           1353     1353              
- Misses          733      845     +112     
  Partials         90       90
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ui/CalendarView.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f015e...e46fa83. Read the comment docs.

@yanbingtao yanbingtao linked an issue Oct 27, 2020 that may be closed by this pull request
As a store manager, I want to have a calendar in the application #134
Closed
@yanbingtao yanbingtao changed the title Creates calendar feature. Create calendar feature. Oct 27, 2020
@ureshiiYing ureshiiYing added priority.Medium Nice to have and removed priority.High Must do labels Oct 27, 2020
@yanbingtao yanbingtao changed the title Create calendar feature. Creates calendar feature Oct 28, 2020
@yanbingtao yanbingtao changed the title Creates calendar feature Create calendar feature Oct 28, 2020
ureshiiYing
ureshiiYing reviewed Oct 28, 2020
View reviewed changes
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual GUI looks good to me. There's some problems in the coding standards that I have commented.

src/main/java/seedu/address/ui/CalendarView.java Outdated Show resolved Hide resolved
@yanbingtao
Copy link
Author

The actual GUI looks good to me. There's some problems in the coding standards that I have commented.

Thank you! I've edited in the latest commit. Thank you!

Diwu-Yi
Diwu-Yi approved these changes Oct 28, 2020
View reviewed changes
Copy link

@Diwu-Yi Diwu-Yi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao changed the title Create calendar feature Implement calendar Oct 28, 2020
Persdre
Persdre approved these changes Oct 28, 2020
View reviewed changes
Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Persdre Persdre merged commit 3cf7c7b into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureshiiYing ureshiiYing ureshiiYing left review comments

@Diwu-Yi Diwu-Yi Diwu-Yi approved these changes

@Persdre Persdre Persdre approved these changes

Assignees

@yanbingtao yanbingtao

Labels
priority.Medium Nice to have type.Story A user story
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a store manager, I want to have a calendar in the application
5 participants
@yanbingtao @codecov-io @Persdre @Diwu-Yi @ureshiiYing