Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Ingredient List GUI and add tests #146

Conversation

Diwu-Yi
Copy link

@Diwu-Yi Diwu-Yi commented Oct 28, 2020

No description provided.

@Diwu-Yi Diwu-Yi self-assigned this Oct 28, 2020
@Diwu-Yi Diwu-Yi added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. labels Oct 28, 2020
@Diwu-Yi Diwu-Yi added this to the v1.3 milestone Oct 28, 2020
@Diwu-Yi
Copy link
Author

Diwu-Yi commented Oct 28, 2020

#147

WM71811
WM71811 previously approved these changes Oct 28, 2020
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #146 into master will increase coverage by 2.14%.
The diff coverage is 34.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
+ Coverage     62.17%   64.32%   +2.14%     
- Complexity      601      628      +27     
============================================
  Files           111      113       +2     
  Lines          2176     2223      +47     
  Branches        262      272      +10     
============================================
+ Hits           1353     1430      +77     
+ Misses          733      692      -41     
- Partials         90      101      +11     
Impacted Files Coverage Δ Complexity Δ
...ngredientcommands/IngredientViewSingleCommand.java 29.62% <ø> (ø) 2.00 <0.00> (ø)
.../logic/commands/ingredientcommands/SetCommand.java 75.00% <ø> (ø) 13.00 <0.00> (?)
...commands/ingredientcommands/SetDefaultCommand.java 100.00% <ø> (ø) 3.00 <0.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 68.96% <ø> (ø) 16.00 <0.00> (ø)
...eedu/address/logic/parser/SetAllCommandParser.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...a/seedu/address/logic/parser/SetCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/address/model/IngredientBook.java 82.14% <ø> (ø) 11.00 <0.00> (ø)
src/main/java/seedu/address/ui/IngredientCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/seedu/address/ui/IngredientListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f015e...95eb1d2. Read the comment docs.

@yanbingtao yanbingtao linked an issue Oct 28, 2020 that may be closed by this pull request
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit eacb95e into AY2021S1-CS2103T-T12-2:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Ingredient List GUI
4 participants