Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reset all ingredients #71

Merged
merged 20 commits into from
Oct 14, 2020
Merged

Implement reset all ingredients #71

merged 20 commits into from
Oct 14, 2020

Conversation

WM71811
Copy link

@WM71811 WM71811 commented Oct 10, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #71 into master will decrease coverage by 1.07%.
The diff coverage is 3.70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     70.34%   69.27%   -1.08%     
- Complexity      524      526       +2     
============================================
  Files            92       93       +1     
  Lines          1649     1676      +27     
  Branches        184      189       +5     
============================================
+ Hits           1160     1161       +1     
- Misses          432      457      +25     
- Partials         57       58       +1
Impacted Files Coverage Δ Complexity Δ
.../ingredientcommands/IngredientResetAllCommand.java 0.00% <0.00%> (ø) 1.00 <1.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 74.07% <100.00%> (+0.99%) 16.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dad252...224fc23. Read the comment docs.

@WM71811 WM71811 added type.Story A user story priority.High Must do labels Oct 13, 2020
@WM71811 WM71811 added this to the v1.2 milestone Oct 13, 2020
@WM71811 WM71811 linked an issue Oct 13, 2020 that may be closed by this pull request
As a second-time user, I can reset all ingredient levels to zero so that I can record new ingredient levels conveniently. #23
Closed
yanbingtao
yanbingtao previously approved these changes Oct 14, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Diwu-Yi
Diwu-Yi previously approved these changes Oct 14, 2020
View reviewed changes
Copy link

@Diwu-Yi Diwu-Yi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WM71811 WM71811 dismissed stale reviews from Diwu-Yi and yanbingtao via d5c205e October 14, 2020 12:04
yanbingtao
yanbingtao previously approved these changes Oct 14, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ureshiiYing
ureshiiYing reviewed Oct 14, 2020
View reviewed changes
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I have left some comments on where I think could be improved on.

src/main/java/seedu/address/logic/commands/ingredientcommands/IngredientResetAllCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/ingredientcommands/IngredientResetAllCommand.java Show resolved Hide resolved
src/main/java/seedu/address/logic/commands/ingredientcommands/IngredientResetAllCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/logic/parser/AddressBookParser.java Outdated Show resolved Hide resolved
yanbingtao
yanbingtao approved these changes Oct 14, 2020
View reviewed changes
Copy link

@yanbingtao yanbingtao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ureshiiYing
ureshiiYing approved these changes Oct 14, 2020
View reviewed changes
Copy link

@ureshiiYing ureshiiYing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanbingtao yanbingtao merged commit 9f5cf2d into AY2021S1-CS2103T-T12-2:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureshiiYing ureshiiYing ureshiiYing approved these changes

@yanbingtao yanbingtao yanbingtao approved these changes

@Diwu-Yi Diwu-Yi Diwu-Yi left review comments

Assignees

@WM71811 WM71811

Labels
priority.High Must do type.Story A user story
Projects
None yet
Milestone
v1.2
5 participants
@WM71811 @codecov-io @yanbingtao @Diwu-Yi @ureshiiYing