Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update javadocs #395

Merged
merged 9 commits into from
Nov 6, 2020
Merged

Update javadocs #395

merged 9 commits into from
Nov 6, 2020

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Nov 5, 2020

Address #386

@seanjyjy seanjyjy added the Code label Nov 5, 2020
@seanjyjy seanjyjy added this to the v1.4 milestone Nov 5, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team November 5, 2020 18:16
@seanjyjy seanjyjy self-assigned this Nov 5, 2020
keanecjy
keanecjy approved these changes Nov 6, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work.

@keanecjy keanecjy merged commit c657659 into AY2021S1-CS2103T-T15-4:master Nov 6, 2020
@seanjyjy seanjyjy mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keanecjy keanecjy keanecjy approved these changes

@shawn-nyk shawn-nyk Awaiting requested review from shawn-nyk

Assignees

@seanjyjy seanjyjy

Labels
Code
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@seanjyjy @keanecjy