Update Gradle to 6.6.1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of Gradle used in this project is 5.2.1, while the latest version available is now 6.6.1.
An upgrade is needed to support additional plugins such as Pitest (which requires Gradle 5.6).
Let us use the Gradle wrapper to upgrade itself. The exact command used is:
gradlew wrapper --gradle-version=6.6.1 --distribution-type=bin
Gradle 6.6.1 release notes: https://docs.gradle.org/6.6.1/release-notes.html
Property archiveName is deprecated and will be removed from Gradle 7 onwards. https://docs.gradle.org/6.6.1/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:archiveName The deprecation warning message suggests using archiveFileName. Let us update the property from archiveName to archiveFileName to stay compliant with the future Gradle 7.
ianyong
added
pr::ready-to-merge ✅
priority.medium 🥈
yongping827
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
The Gradle wrapper was used to update itself. The exact command used was
gradlew wrapper --gradle-version=6.6.1 --distribution-type=bin.Based on warnings generated by Gradle, I found that property
archiveNameis deprecated and will be removed from Gradle 7 onwards. To stay compliant with the future versions of Gradle,archiveNamehas been updated toarchiveFileName.Notes to reviewers:
distribution-type=allmakes the upgrade work differently fromdistribution-type=bin. In particular, there are changes made togradlewandgradlew.bat. I've stuck tobinas that is what the existing project has used, but it may be worth exploring whether it is recommended/necessary to useallto upgrade thegradlewscripts as well.