Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guide for Find Command implementation #166

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

nus-jeff
Copy link

No description provided.

@nus-jeff nus-jeff requested a review from cmang12 March 23, 2023 22:31
@nus-jeff nus-jeff linked an issue Mar 23, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #166 (9630cbc) into master (fb6909e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     79.06%   79.06%           
  Complexity      867      867           
=========================================
  Files           115      115           
  Lines          2474     2474           
  Branches        349      349           
=========================================
  Hits           1956     1956           
  Misses          442      442           
  Partials         76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The find feature allows users to display a list of persons that contains the given keyword of each respective fields.
The feature is facilitated by the `FindCommand` class mainly but Predicate classes are also used.
`FindCommand` extends `Command` and implements the following operation:
* `FindCommand#execute()` — Finds and displats the list of persons in the application that contains the given keyword of each respective fields.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 'displays'?

Copy link

@cmang12 cmang12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmang12 cmang12 merged commit 44ec07f into AY2223S2-CS2103T-T12-4:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update find in UG/DG
2 participants