Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure UI #178

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Restructure UI #178

merged 6 commits into from
Mar 23, 2023

Conversation

zichen-3974
Copy link

Changes:

  • Move command box to bottom of application.
  • Add in placeholder for meet and organise.
  • Change side bar to only hold icons.
  • Change profile bar design.
  • Remove phone, email, address from contact cards, keep only tags.

To do next:

  • Adjust help window to show commands and summary of how to use them.
  • Person profile panel does not update automatically when edited, will only change when view is called. Need to update this.
  • Add pane to show suggested meetup timing and location.
  • Add pane to show scheduled meetups.

@zichen-3974 zichen-3974 added this to the v1.3 milestone Mar 23, 2023
@zichen-3974 zichen-3974 self-assigned this Mar 23, 2023
@zichen-3974 zichen-3974 linked an issue Mar 23, 2023 that may be closed by this pull request
Restructure User Guide #85
Closed
@zichen-3974 zichen-3974 removed a link to an issue Mar 23, 2023
Restructure User Guide #85
Closed
@zichen-3974 zichen-3974 added the modify Existing feature to be modified label Mar 23, 2023
russelltankaimin
russelltankaimin approved these changes Mar 23, 2023
View reviewed changes
Copy link

@russelltankaimin russelltankaimin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Best to let 1 more person to review before merging.

seanfirefox
seanfirefox approved these changes Mar 23, 2023
View reviewed changes
Copy link

@seanfirefox seanfirefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/images/Ui.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @zichen-3974 ! I think you nailed it.

@seanfirefox seanfirefox merged commit 8d39533 into AY2223S2-CS2103T-W14-2:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanfirefox seanfirefox seanfirefox approved these changes

@russelltankaimin russelltankaimin russelltankaimin approved these changes

@izzhafeez izzhafeez Awaiting requested review from izzhafeez

@kennycjy kennycjy Awaiting requested review from kennycjy

Assignees

@zichen-3974 zichen-3974

Labels
modify Existing feature to be modified
Projects
tP
Status: Done
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@zichen-3974 @seanfirefox @russelltankaimin