Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remarks #164

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Add Remarks #164

merged 8 commits into from
Oct 26, 2023

Conversation

RB9823
Copy link

@RB9823 RB9823 commented Oct 25, 2023

Added the ability to add/view/edit remarks.
Remarks are 'optional' and can go to a maximum of 50 characters.

@RB9823 RB9823 self-assigned this Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #164 (8c75326) into master (a762b3a) will increase coverage by 0.13%.
The diff coverage is 80.35%.

@@             Coverage Diff              @@
##             master     #164      +/-   ##
============================================
+ Coverage     74.30%   74.43%   +0.13%     
- Complexity      489      501      +12     
============================================
  Files            81       83       +2     
  Lines          1537     1588      +51     
  Branches        167      176       +9     
============================================
+ Hits           1142     1182      +40     
- Misses          350      356       +6     
- Partials         45       50       +5     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 90.47% <100.00%> (+1.00%) ⬆️
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 87.50% <100.00%> (+1.78%) ⬆️
.../seedu/address/logic/parser/EditCommandParser.java 93.93% <100.00%> (+0.60%) ⬆️
.../java/seedu/address/model/util/SampleDataUtil.java 20.00% <ø> (ø)
.../java/seedu/address/storage/JsonAdaptedPerson.java 93.22% <100.00%> (+0.91%) ⬆️
...java/seedu/address/logic/commands/EditCommand.java 96.80% <87.50%> (-0.90%) ⬇️
...main/java/seedu/address/model/booking/Booking.java 78.84% <83.33%> (-0.33%) ⬇️
src/main/java/seedu/address/ui/BookingCard.java 0.00% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RB9823 RB9823 added this to the v1.3 milestone Oct 26, 2023
@RB9823 RB9823 added the priority.Medium Nice to have label Oct 26, 2023
@iyioon
Copy link

iyioon commented Oct 26, 2023

LGTM

@iyioon iyioon merged commit e36fc40 into AY2324S1-CS2103T-F10-1:master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants