Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract out command parse exceptions into their own package #250

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

markgcera
Copy link

No description provided.

@markgcera markgcera added this to the v1.4 milestone Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #250 (574716d) into master (32a7f0c) will decrease coverage by 0.10%.
Report is 9 commits behind head on master.
The diff coverage is 68.18%.

❗ Current head 574716d differs from pull request most recent head 5294bea. Consider uploading reports for the commit 5294bea to get more accurate results

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     67.31%   67.21%   -0.10%     
- Complexity      518      523       +5     
============================================
  Files            88       94       +6     
  Lines          1857     1876      +19     
  Branches        209      210       +1     
============================================
+ Hits           1250     1261      +11     
- Misses          537      544       +7     
- Partials         70       71       +1     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 90.90% <ø> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 90.90% <100.00%> (-9.10%) ⬇️
.../seedu/address/logic/parser/BookingBookParser.java 91.30% <100.00%> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (ø)
...eedu/address/logic/parser/JsonInjectionParser.java 100.00% <100.00%> (ø)
...parser/exceptions/JsonInjectionParseException.java 100.00% <100.00%> (ø)
...and/parse/exceptions/AddCommandParseException.java 100.00% <100.00%> (ø)
...nd/parse/exceptions/FindCommandParseException.java 100.00% <100.00%> (ø)
...nd/parse/exceptions/HelpCommandParseException.java 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@markgcera markgcera closed this Nov 8, 2023
markgcera added 2 commits November 8, 2023 22:35
* Abstract-Parser-Exceptions:
  Create ParserUtil.parseIndex methods for edit and delete commands

# Conflicts:
#	src/main/java/seedu/address/logic/parser/DeleteCommandParser.java
#	src/main/java/seedu/address/logic/parser/EditCommandParser.java
@markgcera markgcera reopened this Nov 8, 2023
@AryanG01
Copy link

AryanG01 commented Nov 8, 2023

LGTM

@AryanG01 AryanG01 merged commit 2179810 into AY2324S1-CS2103T-F10-1:master Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants