Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch add appointment #218

Closed
wants to merge 123 commits into from
Closed

Branch add appointment #218

wants to merge 123 commits into from

Conversation

cmHuang777
Copy link

  • Added more test cases
  • removed dead code in model class and its implementation

@chonguschonguschongus
Abstract out person class
24b82af
@chonguschonguschongus
Make JsonAdaptedPerson abstract
3dc4230
@chonguschonguschongus
Merge branch 'master' into branch-makePersonAbstract
a3b15f1
@chonguschonguschongus
Make Person class abstract
66f360c
@Mohammed-Faizzzz
Merge pull request AY2324S1-CS2103T-T09-3#123 from chonguschonguschon…
97d9816 
…gus/branch-makePersonAbstract

Make `Person` abstract
@chonguschonguschongus
Improve code coverage
90091dd
@chonguschonguschongus
Improve code coverage
c4a2af8
@chonguschonguschongus
Fix checkstyle
fcf5b12
@chonguschonguschongus
Improve code coverage
15468f7
@chonguschonguschongus
Fix checkstyle
97dd5a5
@chonguschonguschongus
Fix checkstyle
e354460
@tanveersingh10
Merge branch 'master' of https://github.com/AY2324S1-CS2103T-T09-3/tp
2d6c39b
@tanveersingh10
Add logs and assertions
9dadee1
@tanveersingh10
Add logs and assertions
bf65f60
@tanveersingh10
Add more assertions
9177566
@chonguschonguschongus
Fix code quality
d8fcf5b
@chonguschonguschongus
Fix checkstyle
161010c
@chonguschonguschongus
Merge pull request AY2324S1-CS2103T-T09-3#125 from chonguschonguschon…
c68176d 
…gus/branch-improveCodeCoverage

Improve code coverage
@tanveersingh10
Merge branch 'master' of github.com:tanveersingh10/tp
bcced88
@tanveersingh10
Fix error
4540292
@tanveersingh10
Merge branch 'master' into master
45f4d28
@tanveersingh10
Merge pull request AY2324S1-CS2103T-T09-3#126 from tanveersingh10/master
b6c83f5 
Add logs and assertions
@chonguschonguschongus
Fix merge conflicts
70c6692
@chonguschonguschongus
Merge branch 'master' into branch-addDeleteAppointment
d4e55ca
@chonguschonguschongus
Fix test cases
775cd2d
@chonguschonguschongus
Merge branch 'branch-addDeleteAppointment' of https://github.com/chon…
53c68d5 
…guschonguschongus/tp into branch-addDeleteAppointment
@chonguschonguschongus
Fix test cases
d3c108a
@Mohammed-Faizzzz
Merge pull request AY2324S1-CS2103T-T09-3#134 from chonguschonguschon…
83c53bc 
…gus/branch-fixMergeConflictsForAppointment

Fix merge conflicts for addition of Appointment class.
@tanveersingh10
Merge branch 'master' of https://github.com/AY2324S1-CS2103T-T09-3/tp
0c130d3
@tanveersingh10
Modify EditCommand and RemarkCommand
d8120d7
kohkaijie and others added 26 commits November 9, 2023 12:28
@kohkaijie
Merge pull request AY2324S1-CS2103T-T09-3#208 from kohkaijie/sample-d…
c3e6662 
…ate-bug-fix

Fix bug relating to sample data
@cmHuang777
Merge pull request AY2324S1-CS2103T-T09-3#210 from cmHuang777/UpdatePPP
21b41d0 
Update ppp
@chonguschonguschongus
Update PPP
105c600
@chonguschonguschongus
Merge pull request AY2324S1-CS2103T-T09-3#209 from chonguschonguschon…
b9c4757 
…gus/branch-addTestCases

Add test cases
@Mohammed-Faizzzz
Update PPP
c07ab8a
@chonguschonguschongus
Update UG
2a387e5
@kohkaijie
Merge pull request AY2324S1-CS2103T-T09-3#212 from chonguschonguschon…
499b211 
…gus/branch-updateDocs

Update docs
@kohkaijie
Merge pull request AY2324S1-CS2103T-T09-3#211 from Mohammed-Faizzzz/b…
2be2c0a 
…ranch-UpdatePPP

Update PPP
@cmHuang777
Fix bugs from PE-D assigned issues
3ad0124
@cmHuang777
Update branch with upstream
67a44cb
@tanveersingh10
Merge branch 'master' of https://github.com/AY2324S1-CS2103T-T09-3/tp
60fb8c2
@tanveersingh10
remove remark command
0567824
@tanveersingh10
Merge branch 'removeRemark'
09ce28d
@tanveersingh10
Fix duplicate doctors and patients
ec2e75e
@tanveersingh10
Fix adding of doctor and patient with same ic
f061483
@tanveersingh10
Update UG
e4f0ff4
@kohkaijie
Merge pull request AY2324S1-CS2103T-T09-3#213 from cmHuang777/PE-D-Bu…
69090cc 
…gFix

PE-D bug fix
@tanveersingh10
Update PPP
347d38c
@tanveersingh10
Merge pull request AY2324S1-CS2103T-T09-3#214 from tanveersingh10/master
4c68a8a 
Fix bugs from PE-D
@kohkaijie
Update User Guide
817193a 
Added parameter table containing specifications of allowed parameters.
Will update rest of the UG in next commit.
@kohkaijie
Merge branch 'master' of https://github.com/kohkaijie/tp into ug-changes
5494749
@kohkaijie
Update UG and add test cases
7d34310 
Updated UG to resolve minor discrepancies and added test cases checking
for valid NRIC involving non-caps letter inputs.
@Mohammed-Faizzzz
Merge pull request AY2324S1-CS2103T-T09-3#215 from kohkaijie/ug-changes
c6594dd 
Update User Guide
@cmHuang777
Add more test cases and remove dead code
586f803
@cmHuang777
Merge branch 'master' of https://github.com/AY2324S1-CS2103T-T09-3/tp …
ecdf01d 
…into branch-AddAppointment
@cmHuang777
Fix checkstyle and minor UG issues
f953cd9
@cmHuang777 cmHuang777 added the priority.High Must have. label Nov 10, 2023
@cmHuang777 cmHuang777 added this to the v1.4 milestone Nov 10, 2023
@cmHuang777 cmHuang777 requested a review from a team November 10, 2023 17:56
@cmHuang777 cmHuang777 closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority.High Must have.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cmHuang777 @chonguschonguschongus @Mohammed-Faizzzz @tanveersingh10 @kohkaijie