Add StatusCommand #100

ivanleekk · 2023-10-19T17:03:27Z

No description provided.

netlify · 2023-10-19T17:03:32Z

✅ Deploy Preview for shiny-daffodil-45f25f ready!

Name	Link
🔨 Latest commit	`33c27a5`
🔍 Latest deploy log	https://app.netlify.com/sites/shiny-daffodil-45f25f/deploys/653615b874bc170008cc8e97
😎 Deploy Preview	https://deploy-preview-100--shiny-daffodil-45f25f.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-10-19T17:37:41Z

Codecov Report

Merging #100 (bd3e250) into master (f472d4a) will increase coverage by 3.98%.
The diff coverage is 73.46%.

❗ Current head bd3e250 differs from pull request most recent head 33c27a5. Consider uploading reports for the commit 33c27a5 to get more accurate results

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     70.24%   74.22%   +3.98%     
- Complexity      472      473       +1     
============================================
  Files            81       80       -1     
  Lines          1623     1540      -83     
  Branches        156      148       -8     
============================================
+ Hits           1140     1143       +3     
+ Misses          440      355      -85     
+ Partials         43       42       -1

Files	Coverage Δ
src/main/java/seedu/staffsnap/logic/Messages.java	`88.88% <100.00%> (+1.38%)`	⬆️
...ava/seedu/staffsnap/model/applicant/Applicant.java	`89.09% <100.00%> (+7.27%)`	⬆️
...du/staffsnap/logic/parser/ApplicantBookParser.java	`71.87% <0.00%> (+2.17%)`	⬆️
...rc/main/java/seedu/staffsnap/ui/ApplicantCard.java	`0.00% <0.00%> (ø)`
...du/staffsnap/logic/parser/StatusCommandParser.java	`81.81% <81.81%> (ø)`
...n/java/seedu/staffsnap/model/applicant/Status.java	`75.00% <75.00%> (ø)`
.../seedu/staffsnap/logic/commands/StatusCommand.java	`66.66% <66.66%> (ø)`

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

craigtonlian

Looks good!

But I think that resetting the status when Edit is called will break some user flow down the road. Let's discuss how to iron this logic out 😃

craigtonlian · 2023-10-20T08:24:58Z

src/main/java/seedu/staffsnap/logic/commands/EditCommand.java

@@ -109,7 +109,7 @@ private static Applicant createEditedApplicant(
        List<Interview> updatedInterviews = editApplicantDescriptor
                .getInterviews().orElse(applicantToEdit.getInterviews());

-        return new Applicant(updatedName, updatedPhone, updatedEmail, updatedPosition, updatedInterviews);
+        return new Applicant(updatedName, updatedPhone, updatedEmail, updatedPosition, updatedInterviews, null);


Will setting applicant.status to null every time we edit the Applicant cause the status value to be reset when an Edit command is executed?

have replaced this with a proper integration, so now it will retain its status when edited if untouched

craigtonlian · 2023-10-20T08:28:10Z

src/main/java/seedu/staffsnap/model/applicant/Status.java

+                break;
+            }
+        }
+        System.out.println(result);


Is this print statement intended?

oops this was meant for debugging, has been removed in the latest commit

craigtonlian · 2023-10-20T08:30:18Z

src/main/java/seedu/staffsnap/logic/parser/AddCommandParser.java

@@ -46,7 +46,7 @@ public AddCommand parse(String args) throws ParseException {
        Position position = ParserUtil.parsePosition(argMultimap.getValue(PREFIX_POSITION).get());
        List<Interview> interviewList = new ArrayList<>();

-        Applicant applicant = new Applicant(name, phone, email, position, interviewList);
+        Applicant applicant = new Applicant(name, phone, email, position, interviewList, null);


Refer to above 😄

craigtonlian · 2023-10-20T08:32:46Z

src/main/java/seedu/staffsnap/logic/commands/StatusCommand.java

+
+    @Override
+    public String toString() {
+        return "StatusCommand{" + "index=" + index + ", status=" + status + '}';


Perhaps can use ToStringBuilder() to generate the String representation similar to other how the other commands implement toString() 🐶

done too in the latest commit

craigtonlian · 2023-10-20T08:33:08Z

src/main/java/seedu/staffsnap/logic/commands/SortCommand.java

-        */
-        model.updateFilteredApplicantList(PREDICATE_HIDE_ALL_APPLICANTS);
-        model.updateFilteredApplicantList(PREDICATE_SHOW_ALL_APPLICANTS);
+        model.refreshApplicantList();


Niceeeee ❤️

craigtonlian

Looks great! Thanks, Ivan 😄

Add StatusCommand

4ae04a1

ivanleekk added 3 commits October 20, 2023 01:23

Fix checkstyle issue

75127c7

Add status to UI

601a661

Fix testcase in ApplicantTest

e7cfcf7

This was linked to issues Oct 19, 2023

Add Status of Applicant #103

Closed

Add applicant status command #101

Closed

ivanleekk removed a link to an issue Oct 19, 2023

Add Status of Applicant #103

Closed

ivanleekk added 2 commits October 20, 2023 11:57

Add testcases for StatusCommand and ConfirmationCommand

bd3e250

Add status to save file

3378b87

ivanleekk marked this pull request as ready for review October 20, 2023 04:39

ivanleekk added this to the v1.3 milestone Oct 20, 2023

craigtonlian reviewed Oct 20, 2023

View reviewed changes

ivanleekk added 2 commits October 23, 2023 14:22

Remove placeholder null value in EditCommand and AddCommandParser

6d5e847

Merge master and fix bug with ModelManager.refreshApplicantList()

33c27a5

ivanleekk requested a review from craigtonlian October 23, 2023 06:45

craigtonlian approved these changes Oct 23, 2023

View reviewed changes

craigtonlian merged commit 3fa1722 into AY2324S1-CS2103T-W08-1:master Oct 23, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add StatusCommand #100

Add StatusCommand #100

ivanleekk commented Oct 19, 2023

netlify bot commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading

craigtonlian left a comment

craigtonlian Oct 20, 2023

ivanleekk Oct 23, 2023

craigtonlian Oct 20, 2023

ivanleekk Oct 23, 2023

craigtonlian Oct 20, 2023

craigtonlian Oct 20, 2023

ivanleekk Oct 23, 2023

craigtonlian Oct 20, 2023

craigtonlian left a comment

Add StatusCommand #100

Add StatusCommand #100

Conversation

ivanleekk commented Oct 19, 2023

netlify bot commented Oct 19, 2023 • edited Loading

✅ Deploy Preview for shiny-daffodil-45f25f ready!

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

craigtonlian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

craigtonlian left a comment

Choose a reason for hiding this comment

netlify bot commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading