Edit applicant entry #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiny-daffodil-45f25f canceled.
|
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
============================================
+ Coverage 73.97% 74.11% +0.13%
- Complexity 452 458 +6
============================================
Files 77 77
Lines 1483 1491 +8
Branches 139 141 +2
============================================
+ Hits 1097 1105 +8
Misses 351 351
Partials 35 35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
craigtonlian
approved these changes
Oct 18, 2023
| @@ -78,10 +78,17 @@ public CommandResult execute(Model model) throws CommandException { | |||
| Applicant applicantToEdit = lastShownList.get(index.getZeroBased()); | |||
| Applicant editedApplicant = createEditedApplicant(applicantToEdit, editApplicantDescriptor); | |||
|
|
|||
| // Check if edited applicant has the identity as another existing applicant | |||
There was a problem hiding this comment.
Did you mean "if edited applicant has the same identity as another applicant"?
| requireNonNull(applicant); | ||
| return applicants.numberOfDuplicates(applicant) > 1; | ||
| } | ||
|
|
There was a problem hiding this comment.
This duplicate check seems necessary due to the way we are defining identity of applicants. Kudos for spotting this bug! 🎉
AustinHuang1203
merged commit 7cfd650
into
AY2324S1-CS2103T-W08-1:master
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20