-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mark and unmark for tasks #40
Implement mark and unmark for tasks #40
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
============================================
+ Coverage 76.03% 76.31% +0.28%
- Complexity 495 549 +54
============================================
Files 82 92 +10
Lines 1565 1744 +179
Branches 141 161 +20
============================================
+ Hits 1190 1331 +141
- Misses 342 374 +32
- Partials 33 39 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is neat and clean. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far! Do modify the UI to display whether a task is done.
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you have created a util class to better facilitate our testing. The code looks good!
The
MarkTask
CommandThe
marktask
command mark tasks as done. The command has the following format:Parameter:
TASK_INDEX
The task index provided is invalid
is displayed.If the task is already marked, the command is still accepted and succeeds.
Things to note
marktask
does not remove the task from the person.The
UnmarkTask
CommandThe
unmarktask
command mark tasks as undone. The command has the following format:Parameter:
TASK_INDEX
The task index provided is invalid
is displayed.If the task is already unmarked, the command is still accepted and succeeds.
This PR is linked to #6.