Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pull secrets in helm chart #192

Merged
merged 1 commit into from
May 23, 2024

Conversation

mars64
Copy link
Contributor

@mars64 mars64 commented May 7, 2024

Supports the use of imagePullSecrets in deployment and serviceAccount objects. Useful for things like authenticating to DockerHub in systems that would otherwise hit pull limits.

This would close #191

Please note: I bypassed the pre-commit hooks as I did not change any of the Java code and am not currently set up with the required local Gradle toolchain. Apologies in advance.

@mars64
Copy link
Contributor Author

mars64 commented May 7, 2024

For context, it appears that this repo's CI actions are hitting the same issue I had with the pre-commit hooks. See https://github.com/AbdelrhmanHamouda/locust-k8s-operator/actions/runs/8990973580 for more details.

@AbdelrhmanHamouda
Copy link
Owner

Thank you for your contribution to the project and thanks for your patience till i answered this request.

It is true that it seems the actions are hitting an issue and it is not related to you.

I have reviewed your change and I'm accepting it.

Thank you again for the contribution, it is always appreciated :)
I'll work between today and tomorrow to release a new version with your code changes included

@AbdelrhmanHamouda AbdelrhmanHamouda merged commit 7978b78 into AbdelrhmanHamouda:master May 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Support imagePullSecrets in helm chart
2 participants