-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JG: avoid blank lines in bulleted lists #60
Comments
I am a bit confused by this part, as the list's seem close without any spaces. My theory is that the screen reader might be skipping CSS marker(::marker) pseudo element found in the bullet lists. |
Hmm, @ajrgodfrey was able to create a reproducible example with and without the issue. Unfortunately I did not take a copy and cannot reproduce it now. @ajrgodfrey do you still have this example, or can you recreate it? |
OK, cleaned up examples in attached file.
|
Looks like attachments don't come through to GitHub, maybe send to me by email? |
Done. I couldn't paste Rmd into the email as it gets mangled by Outlook.
From: Heather Turner ***@***.***>
Sent: Sunday, September 10, 2023 2:28 AM
To: Abhi-1U/texor ***@***.***>
Cc: Jonathan Godfrey ***@***.***>; Mention ***@***.***>
Subject: Re: [Abhi-1U/texor] JG: avoid blank lines in bulleted lists (Issue #60)
Looks like attachments don't come through to GitHub, maybe send to me by email?
-
Reply to this email directly, view it on GitHub<#60 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADCZKGVXMO2BB5MVQLK6IXTXZR4HNANCNFSM6AAAAAA4QV3WHM>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Okay, this is a simplified version:
However, we tested with So this is mainly an rjtools issue I think, though assuming we can fix it there, it would be good if texor could ensure the Rmd source does not have blank lines between list elements. |
This comes through very badly in my email client. The input looks the same when I read it as an incoming message, but it looks as intended when it appears in the reply. <sigh>
The first example should have one line break and no blank line whereas the second (bad) example has two line breaks and a blank line. The latter comes out very badly when rendered using rmarkdown::render(). The impact when listening to the screen reader is huge even though (as I understand it) there is only a small visual difference
|
I have tried to remove the extra paragraph element from the bullet list using a simple Lua filter. Also this will only affect Meanwhile try out the latest patch of texor on the supplementary articles and check if the issues are resolved or not. |
The patch seems to fix it for the bullet lists. The same problem exists for OrderedLists - in fact it seems to be worse as you always get |
list.zip
list.rmd
|
Or try out the updated texor package with the |
Regarding the > pandoc -t html
## Good bullets
- one
- two
- three
## Bad bullets
- one blah
- two what
- three
^Z
<h2 id="good-bullets">Good bullets</h2>
<ul>
<li>one</li>
<li>two</li>
<li>three</li>
</ul>
<h2 id="bad-bullets">Bad bullets</h2>
<ul>
<li><p>one blah</p></li>
<li><p>two what</p></li>
<li><p>three</p></li>
</ul> You are comparing here the two possible syntax for Bullet List that Pandoc's Markdown offers: "compact" list vs “loose” list. See in their manual: https://pandoc.org/MANUAL.html#bullet-lists
So I believe this is expected for the syntax with space between the items to have
Hope it helps understand |
Comment from @ajrgodfrey
It also affects the visual formatting as a blank line is apparent between each list item - if The R Journal wants more space this should be controlled by the CSS rather than the R markdown/HTML.
The text was updated successfully, but these errors were encountered: