#325 - Add code coverage support improve #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for code coverage GitHub action check as part of PR. - Used Absa fork of JaCoCo solution - with scala method filtering.
- Extend existing yml file to add code coverage measuring as part of them.
JaCoCo code coverage report - Scala 2.12 & Spark 3.2
|
JaCoCo code coverage report - Scala 2.13 & Spark 3.2
|
- Improved title name to avoid confusion about version meaning.
pom.xml
Outdated
| <artifactId>jacoco-maven-plugin</artifactId> | ||
| <version>${jacoco.version}</version> | ||
| <version>0.8.9</version> |
There was a problem hiding this comment.
Could you please add the version back to the variable ${jacoco.version} and use it here? Just for consistency.
There was a problem hiding this comment.
Fixed in commit ede6725.
- Adding version variable for JaCoCo library.
Zejnilovic
approved these changes
Apr 27, 2023
miroslavpojer
deleted the
feature/325_Improve_code_coverage_add_GH_check_action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #325