-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streaming functions for doobie and slick with tests #108
base: master
Are you sure you want to change the base?
Changes from 74 commits
91f4e39
5045b8a
15e9603
264f510
27fac52
c1baa58
d12d96a
804035d
d83b274
491e235
088065f
d766c25
6f0845e
991b446
8bd682e
25c42ec
1b789bb
a95d958
f49645c
b76801b
d75b13a
a3784d7
bcd8d75
3a1f740
bd2a21f
45e483e
6684599
320073e
62f62b7
88fce85
299dde5
0c58a68
84e30ef
5f95411
6cd018d
e4a16f7
742ab50
80a72d4
af15e7f
6711e88
43b60c4
414cfa0
f5db217
03a4a58
852bf6d
7695b29
2799189
9a2eeea
e3c6e7f
b8a4338
94d0212
f647caa
cdb6feb
712ac82
6efd571
a8a6860
e3bf15a
50d7a3a
b542bfc
e4e8edc
2cbc4f7
bf49ae9
5d57f4a
32e9bf8
780a2bd
8144e89
bc729ea
3fbd923
4470c43
7fdf6e4
e8a5607
921f0e6
0268e9a
0a58735
627a554
ad36f5f
5e45619
cb1fe0e
fb92e83
64dbe90
05abfd4
6b76004
8c7a17a
57ec737
d14b7d4
228177c
2d1fc37
db1d6e5
7ce5288
c70ff3b
c000455
2fd7487
a70daee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,14 +29,14 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
include: | ||
- scala: 2.11.12 | ||
scalaShort: "2.11" | ||
overall: 0.0 | ||
changed: 80.0 | ||
- scala: 2.12.17 | ||
scalaShort: "2.12" | ||
overall: 0.0 | ||
changed: 80.0 | ||
- scala: 2.13.12 | ||
scalaShort: "2.13" | ||
overall: 0.0 | ||
changed: 80.0 | ||
name: Build and test | ||
steps: | ||
- name: Checkout code | ||
|
@@ -53,6 +53,7 @@ jobs: | |
${{ github.workspace }}/core/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/examples/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/slick/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/doobie/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
key: ${{ runner.os }}-${{ matrix.scalaShort }}-${{ hashFiles('**/jacoco.xml') }} | ||
|
||
jacoco: | ||
|
@@ -62,14 +63,14 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
include: | ||
- scala: 2.11.12 | ||
scalaShort: "2.11" | ||
overall: 0.0 | ||
changed: 80.0 | ||
- scala: 2.12.17 | ||
scalaShort: "2.12" | ||
overall: 0.0 | ||
changed: 80.0 | ||
- scala: 2.13.12 | ||
scalaShort: "2.13" | ||
overall: 0.0 | ||
changed: 80.0 | ||
name: JaCoCo Code Coverage ${{matrix.scala}} | ||
steps: | ||
- name: Checkout code | ||
|
@@ -80,6 +81,7 @@ jobs: | |
${{ github.workspace }}/core/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/examples/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/slick/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/doobie/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
key: ${{ runner.os }}-${{ matrix.scalaShort }}-${{ hashFiles('**/jacoco.xml') }} | ||
- name: Setup Scala | ||
uses: olafurpg/setup-scala@v10 | ||
|
@@ -92,6 +94,7 @@ jobs: | |
paths: > | ||
${{ github.workspace }}/core/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml, | ||
${{ github.workspace }}/slick/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
${{ github.workspace }}/doobie/target/scala-${{ matrix.scalaShort }}/jacoco/report/jacoco.xml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not agree with removing the code coverage fail-check logic - see the comment on the end of the file. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @miroslavpojer I am not satisfied with this situation either. Unfortunately I couldn't perform merge of previous pull request with this check in place. Let's work together to find a good solution so we can perform tests against a database both locally and within a Github pipeline; for instance with a dockerized Postgres instance. |
||
# examples don't need code coverage - at least not now | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
min-coverage-overall: ${{ matrix.overall }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,3 +46,5 @@ dist | |
test-output | ||
build.log | ||
.bsp | ||
/.bloop/ | ||
/.metals/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
version = "3.5.3" | ||
runner.dialect = scala213 | ||
|
||
maxColumn = 120 | ||
|
||
align.preset = some | ||
align.multiline = false | ||
|
||
align.tokens = [ | ||
{ | ||
code = "<-" | ||
}, | ||
{ | ||
code = "=>" | ||
owners = [{ | ||
regex = "Case" | ||
}] | ||
} | ||
] | ||
|
||
indent.main = 2 | ||
indent.defnSite = 2 | ||
|
||
lineEndings = unix | ||
|
||
docstrings.blankFirstLine = yes | ||
docstrings.style = AsteriskSpace | ||
docstrings.wrap = no | ||
docstrings.removeEmpty = true | ||
|
||
align.openParenDefnSite = false | ||
align.openParenCallSite = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.