issue #757 Initialization failure handling control #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wajda
force-pushed
the
feature/spline-spark-agent-757
branch
from
e3cb356
to
5ddc472
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
JaCoCo code coverage report
|
|
As I understand it there are three places from which agent code is run:
Spark listener is wrapped in try catch, so we can't influence what is happening outside of that. For both init methods are you sure there is no catch block that will make this config unusable? |
|
Can we have tests for this? |
wajda
force-pushed
the
feature/spline-spark-agent-757
branch
from
5ddc472
to
5f72185
Compare
wajda
force-pushed
the
feature/spline-spark-agent-757
branch
from
5f72185
to
dbed035
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #757
Adds a new config property:
spline.onInitFailure = LOG | BREAKLOG- log the error and carry on with Spark job (default behavior)BREAK- propagate the error to the calling Spark process.