Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #757 Initialization failure handling control #758

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Oct 23, 2023

fixes #757

Adds a new config property:

spline.onInitFailure = LOG | BREAK
  • LOG - log the error and carry on with Spark job (default behavior)
  • BREAK - propagate the error to the calling Spark process.

@wajda wajda force-pushed the feature/spline-spark-agent-757 branch from e3cb356 to 5ddc472 Compare October 23, 2023 16:21
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wajda wajda requested a review from cerveada October 23, 2023 16:23
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

JaCoCo code coverage report

File Coverage [40.56%]
AgentConfig.scala 84.38% 🍏
AgentBOM.scala 72.85%
InitFailureHandlingMode.java 0%
SparkLineageInitializer.scala 0%
Total Project Coverage 42.07% 🍏

@cerveada
Copy link
Contributor

As I understand it there are three places from which agent code is run:

  • Programmatic init
  • codeless init
  • Spark listener

Spark listener is wrapped in try catch, so we can't influence what is happening outside of that. For both init methods are you sure there is no catch block that will make this config unusable?

@cerveada
Copy link
Contributor

Can we have tests for this?

@wajda wajda force-pushed the feature/spline-spark-agent-757 branch from 5ddc472 to 5f72185 Compare July 9, 2024 18:15
@wajda wajda force-pushed the feature/spline-spark-agent-757 branch from 5f72185 to dbed035 Compare July 9, 2024 20:57
Copy link

sonarcloud bot commented Jul 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization failure handling control
2 participants