Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/spline 1266 tx info discrepancy and index #1267

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Bugfix/spline 1266 tx info discrepancy and index #1267

merged 6 commits into from
Sep 6, 2023

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Sep 5, 2023

Fixes #1266

  1. Rename _tx_info into _txInfo as it should be
  2. Improve document removal query performance on TX rollback by only filtering on _txInfo.uid instead of the entire _txInfo object.
  3. Add persistent index on _txInfo.uid to all graph nodes and edges
  4. Fix some minor deprecations

@wajda wajda requested a review from cerveada as a code owner September 5, 2023 00:09
@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

JaCoCo code coverage report

File Coverage [52.85%] ❌
AdminCLI.scala 85.72% 🍏
ArangoManager.scala 54.1% ❌
persistentDefs.scala 1.74% ❌
ArangoDatabaseFacade.scala 0% ❌
Total Project Coverage 35.71% 🍏

cerveada
cerveada previously approved these changes Sep 5, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wajda wajda merged commit 3143bbc into develop Sep 6, 2023
3 of 4 checks passed
@wajda wajda deleted the bugfix/spline-1266-txInfo-discrepancy-and-index branch September 6, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cerveada cerveada cerveada left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TxInfo property name discrepancy, and missing index.
2 participants
@wajda @cerveada