Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1332 - Upgrade to Scala 2.13 #1333

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Jun 3, 2024

fixes #1332

@wajda wajda requested a review from cerveada as a code owner June 3, 2024 22:21
Snyk has created this PR to upgrade org.scala-lang:scala-library from 2.12.19 to 2.13.14.

See this package in maven:
org.scala-lang:scala-library

See this project in Snyk:
https://app.snyk.io/org/wajda/project/cb08aba9-ae42-4c2d-8b5f-f02ed8d0264b?utm_source=github&utm_medium=referral&page=upgrade-pr
@wajda wajda force-pushed the feature/upgrade-to-scala-2.13 branch from 9836cb1 to 40a9d65 Compare June 3, 2024 22:25
@wajda wajda force-pushed the feature/upgrade-to-scala-2.13 branch from 9c987c1 to 0d7992a Compare June 3, 2024 23:38
@wajda wajda force-pushed the feature/upgrade-to-scala-2.13 branch from 0d7992a to 1ea5918 Compare June 3, 2024 23:55
Comment on lines 64 to 66
logger.warn("" +
s"DST gap was detected for the input '$s' in the time zone '$tz'. " +
s"Continue with the adjusted datetime '$zdt''")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.warn("" +
s"DST gap was detected for the input '$s' in the time zone '$tz'. " +
s"Continue with the adjusted datetime '$zdt''")
logger.warn(
s"DST gap was detected for the input '$s' in the time zone '$tz'. " +
s"Continue with the adjusted datetime '$zdt'"
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same bellow

@wajda wajda force-pushed the feature/upgrade-to-scala-2.13 branch from a522e03 to cc92d9e Compare June 4, 2024 12:52
cerveada
cerveada previously approved these changes Jun 4, 2024
Copy link
Contributor

@cerveada cerveada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cerveada
cerveada previously approved these changes Jun 4, 2024
cerveada
cerveada previously approved these changes Jun 4, 2024
@wajda wajda force-pushed the feature/upgrade-to-scala-2.13 branch from 4dfa39b to f69661c Compare June 4, 2024 20:30
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@wajda wajda merged commit 362da1a into develop Jun 4, 2024
4 of 7 checks passed
@wajda wajda deleted the feature/upgrade-to-scala-2.13 branch June 4, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Scala 2.13
3 participants