Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT governance refactor #382

Merged
merged 69 commits into from
Jul 11, 2024
Merged

NFT governance refactor #382

merged 69 commits into from
Jul 11, 2024

Conversation

CyberHoward
Copy link
Contributor

@CyberHoward CyberHoward commented Jun 20, 2024 •
edited by Buckram123
Loading

Checklist

  • CI is green.
  • Changelog updated.

hard-nett and others added 23 commits June 4, 2024 06:52
add nft GovernanceDetail
d0f21ec
add basic test
279f635
confirm only nft holder can call account
584954e
move cw721 crates to dev dependencies
a94833b
add cw-orch & updated BITSONG
42f92e8
@hard-nett
Merge branch 'main' into nft-governance-details
69b5ca1
remove bitsong deps
b7f9dae
Merge branch 'nft-governance-details' of https://github.com/permissio…
e200115 
…nlessweb/bitsong-abstract into nft-governance-details
cleanup
43becba
remove option to pass querier for owner_address
99c8fe5
@hard-nett @adairrr
Update framework/packages/abstract-std/src/objects/gov_type.rs
51032e4 
Co-authored-by: Interchain Adair <32375605+adairrr@users.noreply.github.com>
@hard-nett
Merge branch 'main' into nft-governance-details
94fba5e
temp revert to passing owner_address optional type
168a77a
return nft owner in admin recursion loops
130d84c
@Kayanski
Better governance query
15fa43d
@hard-nett
Merge pull request #2 from AbstractSDK/nft-governance-details
2ee29f2 
Better governance query
move nft ownership query & add ownership error to abstract-std
61f2da5
@hard-nett
Merge branch 'main' into nft-governance-details
7bf7f0c
@CyberHoward
clean up dependencies
32e318b
@CyberHoward
cleanup
852aa4b
@CyberHoward
refactor manager ownership assertion
ebf9a49
@CyberHoward
clippy and fmt
abb4cde
@CyberHoward
env propagation
8d33129
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 19f3f58
Status: ✅  Deploy successful!
Preview URL: https://331f7dbd.abstract-docs.pages.dev
Branch Preview URL: https://nft-gov-refactor.abstract-docs.pages.dev

View logs

CyberHoward
CyberHoward commented Jul 10, 2024
View reviewed changes
Copy link
Contributor Author

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Buckram123
Buckram123 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CyberHoward CyberHoward mentioned this pull request Jul 10, 2024
Closed
2 tasks
@CyberHoward CyberHoward merged commit 8724996 into main Jul 11, 2024
10 of 13 checks passed
@CyberHoward CyberHoward deleted the nft-gov-refactor branch July 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

Assignees
No one assigned
Labels
account adapter_base app_base documentation Improvements or additions to documentation interface native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CyberHoward @codecov-commenter @Buckram123 @hard-nett @Kayanski