Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of range node with inverted output and clamp #1749

Open
makkbru opened this issue Mar 25, 2024 · 3 comments
Open

Fix behavior of range node with inverted output and clamp #1749

makkbru opened this issue Mar 25, 2024 · 3 comments

Comments

@makkbru
Copy link

makkbru commented Mar 25, 2024

when the range node is used to invert the input, activating clamp will make it output the wrong result. its probably clamping to min and max in the input without checking if the min value is smaller than the max value

@jstone-lucasfilm
Copy link
Member

Adding a link to the current graph definition of the range node in MaterialX:

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/libraries/stdlib/stdlib_ng.mtlx#L3568

@jstone-lucasfilm jstone-lucasfilm changed the title range node does not work with inverted output when clamp is enabled Fix behavior of range node with inverted output and clamp Sep 23, 2024
@sckleung
Copy link

Hello, I am a new contributor for ASWF Dev Days this year and would like to look in to this as a first issue. I am unable to log on to the Slack channel currently.

@jstone-lucasfilm
Copy link
Member

Welcome @sckleung! Here's a link that we often recommend for creating an ASWF Slack account, and you can find our team there under #materialx.

https://www.aswf.io/get-involved/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants