Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Built-In Transform support for Apple Log #1916

Closed
carolalynn opened this issue Dec 5, 2023 · 3 comments · Fixed by #1941
Closed

Add Built-In Transform support for Apple Log #1916

carolalynn opened this issue Dec 5, 2023 · 3 comments · Fixed by #1941
Labels
Feature Request New addition to OCIO functionality.
Milestone

Comments

@carolalynn
Copy link
Collaborator

Related to the request to add Apple Log support to the OCIO Configs:

AcademySoftwareFoundation/OpenColorIO-Config-ACES#120

We should add built-in transform support to the library to enable the configs to be LUT-free.

Reference implementation:
A CTL-based Apple Log IDT was recently added to aces-dev at:
https://github.com/ampas/aces-dev/tree/dev/transforms/ctl/idt/vendorSupplied/apple

Documentation:
The official white paper, and example 1D LUT (.cube) are located here:
https://developer.apple.com/download/all/?q=Apple%20log%20profile

@JGoldstone
Copy link
Contributor

Are you looking for a NamedTransform for the curve in addition to the ColorSpace transform? Or just the latter?

@carolalynn carolalynn linked a pull request Feb 5, 2024 that will close this issue
@carolalynn carolalynn added the Feature Request New addition to OCIO functionality. label Feb 7, 2024
@carolalynn carolalynn added this to the OCIO 2.4.0 milestone Feb 7, 2024
@doug-walker
Copy link
Collaborator

I'm reopening this issue after looking at some purported footage in Apple Log space and it looks questionable. But I'm not sure if it's our transform or the media.

@rkmolho Could you direct us to some known good test footage?

@doug-walker doug-walker reopened this Feb 13, 2024
@doug-walker
Copy link
Collaborator

We shot some of our own test footage of charts and based on that, I think the results actually are pretty much as expected. (We were really thrown off by the samples that we had been provided earlier, which must not have been done correctly.) If we get official samples from Apple, that would definitely add some certainty around what to expect. In the meantime, I'll close this.

I noticed that the half-domain Lut1D eventually overflows at extreme values. It would be nice to revisit that, but that could be done as a follow up. Given that the nonlinearity has a hard-clip on the bottom end, probably the best approach would be to use a normal-domain Lut1D that covers [0,2] in Apple Log space, with a matrix in front to set the domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New addition to OCIO functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants