Assertion overhaul #1080
Merged
Assertion overhaul #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New macros: * OSL_ASSERT / OSL_ASSERT_MSG -- always test, always print error if the test fails, abort only in debug build. * OSL_DASSERT / OSL_DASSERT_MSG -- debug mode only test, print, abort. Does nothing for release build. Eschew the old OIIO macros ASSERT/DASSERT, since it is perferable to not purposely abort when in release mode. Ported over from OIIO copies of a few other related macros. This patch just adds definitions, we will change the existing macros in subsequent PRs.
|
Merging because this only adds things, can't break existing code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New macros:
OSL_ASSERT / OSL_ASSERT_MSG -- always test, always print error if the
test fails, abort only in debug build.
OSL_DASSERT / OSL_DASSERT_MSG -- debug mode only test, print, abort.
Does nothing for release build.
Eschew the old OIIO macros ASSERT/DASSERT, since it is perferable to not
purposely abort when in release mode.
Ported over from OIIO copies of a few other related macros.
This patch just adds definitions, we will change the existing macros
in subsequent PRs.