Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash generating closure functions calls with LLVM 11 #1361

Merged
merged 1 commit into from Apr 22, 2021
Merged

Fix crash generating closure functions calls with LLVM 11 #1361

merged 1 commit into from Apr 22, 2021

Conversation

brechtvl
Copy link
Contributor

Description

Generating code for calling prepare_closure and gen_closure was crashing in Blender, with macOS arm64 and LLVM 11.

The code now matches the implementation of the removed LLVM function. For reference:
llvm/llvm-project@836ce9d

Tests

Existing OSL tests were already crashing, so this is covered.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@brechtvl brechtvl mentioned this pull request Apr 19, 2021
Closed
@brechtvl
Copy link
Contributor Author

(I'm resolving the CLA thing, may be a day or two.)

@brechtvl
Fix crash generating closure functions calls with LLVM 11
84c26c0 
Generating code for prepare_closure and gen_closure was crashing.
The code now matches the implementation of the removed LLVM function.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
@lgritz lgritz merged commit ab7107c into AcademySoftwareFoundation:master Apr 22, 2021
@lgritz lgritz mentioned this pull request Apr 22, 2021
Closed
lgritz pushed a commit to lgritz/OpenShadingLanguage that referenced this pull request Apr 22, 2021
@brechtvl @lgritz
Fix crash generating closure functions calls with LLVM 11 (AcademySof…
ac46738 
…twareFoundation#1361)

Generating code for prepare_closure and gen_closure was crashing.
The code now matches the implementation of the removed LLVM function.

Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brechtvl @lgritz