Fix memory leaks found by static analysis in leparse.cpp #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several places in leparse.cpp were found by static analysis to have memory leaks -- results of calling _parse() that, in the case of early exists in error conditions, never got deleted. I also did some other modernization: changed NULL to nullptr, changed some loops to more compact range-for, utilize some Strutil helpers that will be more efficient than the alternative std::string manipulation. Signed-off-by: Larry Gritz <lg@larrygritz.com>
aconty
approved these changes
Sep 29, 2022
|
If I was smart, I would just have fixed the leak and moved on. (Yay for static analysis!) I couldn't control myself on the range for loops, they were just sitting there calling to me. I started to do a bigger refactor with std::unique_ptr and eliminating all the delete calls entirely, but stopped myself. There is zero need to go down that rathole, the code works as it is and the fact that it has barely been touched for 10 years attests to that. |
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 10, 2022
…wareFoundation#1593) Several places in leparse.cpp were found by static analysis to have memory leaks -- results of calling _parse() that, in the case of early exists in error conditions, never got deleted. I also did some other modernization: changed NULL to nullptr, changed some loops to more compact range-for, utilize some Strutil helpers that will be more efficient than the alternative std::string manipulation. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several places in leparse.cpp were found by static analysis to have memory leaks -- results of calling _parse() that, in the case of early exists in error conditions, never got deleted.
I also did some other modernization: changed NULL to nullptr, changed some loops to more compact range-for, utilize some Strutil helpers that will be more efficient than the alternative std::string manipulation.
Signed-off-by: Larry Gritz lg@larrygritz.com