Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform.h: fully define bitcast template #1635

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Jan 6, 2023

Ported from OIIO. This lets us not have to depend on the specific definition in OIIO's fmath.h, and in particular not worry about whether it's a new enough version of OIIO that the old bit_cast is now marked as deprecated.

Signed-off-by: Larry Gritz lg@larrygritz.com

@lgritz lgritz requested a review from AlexMWells January 6, 2023 05:02
Copy link
Contributor

@AlexMWells AlexMWells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ported from OIIO. This lets us not have to depend on the specific
definition in OIIO's fmath.h, and in particular not worry about
whether it's a new enough version of OIIO that the old bit_cast is now
marked as deprecated.

Signed-off-by: Larry Gritz <lg@larrygritz.com>
@lgritz lgritz merged commit 66c9b61 into AcademySoftwareFoundation:main Jan 13, 2023
@lgritz lgritz deleted the lg-bitcast branch January 13, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants