adding relaxed type-equivalency to ReParameter() #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
reviewed
Jan 23, 2023
src/include/osl_pvt.h
Outdated
| @@ -404,6 +404,7 @@ class TypeSpec { | |||
| bool m_closure; ///< Is it a closure? (m_simple also used) | |||
| }; | |||
|
|
|||
| bool relaxed_equivalent(const TypeDesc& a, const TypeDesc& b); | |||
There was a problem hiding this comment.
Let's move this above to right after 'equivalent' and declare as a friend.
|
@cmstein, can you please fix the clang-format (a line each in typedesc.cpp and shadingsys.cpp) and also edit the last commit you have to be sure it has the "Signed-off-by:" message for the DCO? Thanks. I tried to do this myself, but for some reason can't seem to push it back to your branch (despite the message saying "Add more commits by pushing to the relaxed_equiv branch on cmstein/OpenShadingLanguage.", which I should be able to do as the maintainer of the project. I'm not sure why this doesn't work. |
Signed-off-by: Clifford Stein <cstein@imageworks.com>
cmstein
force-pushed
the
relaxed_equiv
branch
from
2bec156
to
51002ce
Compare
|
fixed clang-format issues and squashed the commits |
lgritz
approved these changes
Jan 25, 2023
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Jan 28, 2023
…dation#1639) Signed-off-by: Clifford Stein <cstein@imageworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clifford Stein cstein@imageworks.com
Description
Allows ShadingSystem->ReParameter() to use the same relaxed rules as SS->Parameter()
Tests
no changes in tests
Checklist: