Expose llvm groupdata size as a shadergroup attribute #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
lgritz
reviewed
Feb 3, 2023
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Feb 20, 2023
…eFoundation#1642) Signed-off-by: Chris Hellmuth <chellmuth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Hellmuth chellmuth@gmail.com
Description
Adds the
llvm_groupdata_sizeattribute so the renderer can inspect a shader group's GroupData struct size. On GPU this lets us reserve memory more efficiently.Tests
No changes.
Checklist: