Fix mismatched strides when calling OCIO for transformc with derivs #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting an exception thrown on the OCIO side, because we were passing 0 for the y stride (which, us humans know, should have been fine since there was only one row, so the stride shouldn't have mattered). Now pass the right stride even though we don't need to step from row to row. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Feb 20, 2023
…cademySoftwareFoundation#1646) We were getting an exception thrown on the OCIO side, because we were passing 0 for the y stride (which, us humans know, should have been fine since there was only one row, so the stride shouldn't have mattered). Now pass the right stride even though we don't need to step from row to row. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Mar 16, 2023
…cademySoftwareFoundation#1646) We were getting an exception thrown on the OCIO side, because we were passing 0 for the y stride (which, us humans know, should have been fine since there was only one row, so the stride shouldn't have mattered). Now pass the right stride even though we don't need to step from row to row. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting an exception thrown on the OCIO side, because we were passing 0 for the y stride (which, us humans know, should have been fine since there was only one row, so the stride shouldn't have mattered). Now pass the right stride even though we don't need to step from row to row.