testrender: Don't use the cached background map on the first bounce #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…camera ray) Signed-off-by: Chris Kulla <ckulla@gmail.com>
fpsunflower
force-pushed
the
allow-bg-raytype
branch
from
ce748c5
to
8a50d78
Compare
…mportance sampling is enabled by default Signed-off-by: Chris Kulla <ckulla@gmail.com>
|
As discussed on slack, I also bumped the default resolution in the event that someone forgets to set it in the xml so that we get better sampling out of the box. |
|
I think that this changes a couple of the test outputs slightly so they need new ref images. If you don't have time to do that tonight, I believe I can just retrieve the updated images from the CI and push another commit on top of yours that fixes it. |
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Mar 1, 2023
…cademySoftwareFoundation#1649) * testrender: Don't use the cached background map on the first bounce (camera ray) * testrender: Change the default resolution of the background so that importance sampling is enabled by default Signed-off-by: Chris Kulla <ckulla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users customize the behavior of the background for camera rays (requested by the MaterialX team). Without this, you always get the cached copy which is only valid for one raytype (and has limited resolution) or you don't get any importance sampling of the environment.