build(cmake): Fix incorrect variable name to control symbol visibility #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Fabrice Macagno pointed out on the oiio-dev mail list, we weren't setting the correct variable name CMAKE_CXX_VISIBILITY_PRESET. And, oops, this also revealed that there were some things that needed to be declared public that were not (because, specifically, they needed to be called across library boundaries by the per-ISA dynamic libraries used by batch shading!). Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
merged commit 089268b
into
AcademySoftwareFoundation:main
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Fabrice Macagno pointed out on the oiio-dev mail list, we weren't setting the correct variable name CMAKE_CXX_VISIBILITY_PRESET.
And, oops, this also revealed that there were some things that needed to be declared public that were not (because, specifically, they needed to be called across library boundaries by the per-ISA dynamic libraries used by batch shading!).