Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed/unsigned comparison #823

Closed
meshula opened this issue Oct 28, 2020 · 1 comment
Closed

Signed/unsigned comparison #823

meshula opened this issue Oct 28, 2020 · 1 comment
Labels
bug A problem, flaw, or broken functionality.

Comments

@meshula
Copy link
Collaborator

meshula commented Oct 28, 2020

Bug Report

Incorrect Functionality

/opt/OpenTimelineIO/source/src/opentimelineio/imageSequenceReference.cpp: In member function ‘std::string opentimelineio::v1_0::ImageSequenceReference::target_url_for_image_number(int, opentimelineio::v1_0::ErrorStatus*) const’:
/opt/OpenTimelineIO/source/src/opentimelineio/imageSequenceReference.cpp:90:39: warning: comparison of integer expressions of different signedness: ‘std::__cxx11::basic_string<char>::size_type’ {aka ‘long unsigned int’} and ‘const int’ [-Wsign-compare]
   90 |         if (image_num_string.length() <  _frame_zero_padding) {
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
@meshula meshula added the bug A problem, flaw, or broken functionality. label Oct 28, 2020
@ssteinbach ssteinbach added this to the Public Beta 14 milestone Oct 22, 2021
@ssteinbach
Copy link
Collaborator

Fixed by #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem, flaw, or broken functionality.
Projects
None yet
Development

No branches or pull requests

2 participants