Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3 in the "rv_session" adapter. #1267

Merged
merged 1 commit into from Apr 11, 2022

Conversation

avrata
Copy link
Contributor

@avrata avrata commented Apr 7, 2022

This can be used with rv versions that support python 3

Link the Issue(s) this Pull Request is related to.

Fixes #1264

Summarize your change.

The rv_session adapter was written in a time before any version of rv supported python 3. That's now a supported version of python so this change enables python 3 for this adapter.

Add a list of changes, and note any that might need special attention during review.

Reference associated tests.

There was one issue with testing where the connections list was not stable between python versions. I think this is due to dict order differences used in the rvSession.py's nodes dict.

This can be used with rv versions that support python 3
@codecov-commenter
Copy link

Codecov Report

Merging #1267 (392df8e) into main (1d3080e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
- Coverage   86.17%   86.15%   -0.02%     
==========================================
  Files         196      196              
  Lines       19697    19701       +4     
  Branches     2309     2310       +1     
==========================================
  Hits        16973    16973              
- Misses       2162     2166       +4     
  Partials      562      562              
Flag Coverage Δ
py-unittests 86.15% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrib/opentimelineio_contrib/adapters/extern_rv.py 0.00% <0.00%> (ø)
contrib/opentimelineio_contrib/adapters/rv.py 15.75% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3080e...392df8e. Read the comment docs.

Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jminor jminor merged commit b426fe1 into AcademySoftwareFoundation:main Apr 11, 2022
jminor pushed a commit that referenced this pull request May 2, 2022
Co-authored-by: Robyn Rindge <rnr@pixar.com>
@ssteinbach ssteinbach added this to the Public Beta 15 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rv_session adapter does not work with python 3+
4 participants