Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use system Python; CI tests all python versions #127

Merged
merged 4 commits into from
Jul 11, 2017
Merged

Only use system Python; CI tests all python versions #127

merged 4 commits into from
Jul 11, 2017

Conversation

mikemahony
Copy link
Collaborator

Travis CI will test all Python versions, including nightly builds.

@ssteinbach
Copy link
Collaborator

After chewing on this all weekend, can we reduce the list to python2.7 and 3.5? Since those are the two versions we're advertising support for, I think those are the only two versions we should really focus on testing. Also, @reinecke do you see any problems with losing the explicit 3.5 test targets and falling back on system python? Or is that an issue for your development workflow?

@reinecke
Copy link
Collaborator

This sounds great to me! I'm using virtualenv-based workflows entirely now, so this actually makes sure when I run the tests they'll happen for the env I'm working in.

I had actually been feeling guilt over introducing the hard-coded version test targets the other day, it never felt quite right to me.

Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only requested change is reducing the number of tested python versions to the two supported ones. Thanks!

.travis.yml Outdated
- "3.3"
- "3.4"
- "3.5"
- "3.5-dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I think we can narrow this list down to 2.7 and the 3.5 variants though, since those are the versions we explicitly support.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Slimmed to 2.7 and 3.5.

README.md Outdated
@@ -1,6 +1,8 @@
OpenTimelineIO
==============

[![Build Status](https://www.travis-ci.com/PixarAnimationStudios/OpenTimelineIO.svg?token=XCu1kiDYTaUqGyY883AU&branch=master)](https://www.travis-ci.com/PixarAnimationStudios/OpenTimelineIO)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for adding this!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapped this out (we're still private) for the python versions badge.

@ssteinbach ssteinbach merged commit 07fd4d7 into AcademySoftwareFoundation:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants