Fix setuptools deprecation warnings #1317
Conversation
…dered as data files Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1317 +/- ##
=======================================
Coverage 86.17% 86.17%
=======================================
Files 195 195
Lines 19806 19806
Branches 2313 2313
=======================================
Hits 17068 17068
Misses 2174 2174
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
With the tests now included in the sdist, does that include the sample data associated with the tests also? Is there any concern about that being large? It might actually be handy to have those available, but I want to make sure we're being thoughtful about side effects. |
|
@jminor Tests sample data will be included in the sdists. I added a diff for the sdists as a collapsible section in the PR description if you want to take a look. As for the size, the old sdist was 293K bytes while the new one is 2.6M. I don't think we should be concerned with that unless we start to add huge sample data. |
…dered as data files (AcademySoftwareFoundation#1317) Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Signed-off-by: Michele Spina <michelespina96@gmail.com>
Fix setuptools deprecation warnings related to importable files considered as data files. Such a warning can be seen at https://github.com/AcademySoftwareFoundation/OpenTimelineIO/runs/6563968215?check_suite_focus=true#step:8:414.
To fix this, I had to unset
include_package_datawhich is not necessary to be set in our case.Changes:
opentimelineio_contrib/adapters/testsandopentimelineio_contrib/application_pluginsare no more included in thw built wheels.How to test:
SOURCE_DATE_EPOCH=315532800 python -m build -w .and then renamedist/OpenTimelineIO-0.15.0.dev1-cp310-cp310-linux_x86_64.whltodist/OpenTimelineIO-0.15.0.dev1-cp310-cp310-linux_x86_64.whl_before.rm -rf build/ OpenTimelineIO.egg-info/(Important!)SOURCE_DATE_EPOCH=315532800 python -m build -w ..diff <(unzip -l dist/OpenTimelineIO-0.15.0.dev1-cp310-cp310-linux_x86_64.whl_before) <(unzip -l dist/OpenTimelineIO-0.15.0.dev1-cp310-cp310-linux_x86_64.whl)The same can be done for the sdist:
SOURCE_DATE_EPOCH=315532800 python -m build -s .and renamedist/OpenTimelineIO-0.15.0.dev1.tar.gztodist/OpenTimelineIO-0.15.0.dev1.tar.gz_beforerm -rf build/ OpenTimelineIO.egg-info/(Important!)SOURCE_DATE_EPOCH=315532800 python -m build -s .diff <(tar tf dist/OpenTimelineIO-0.15.0.dev1.tar.gz_before) <(tar tf dist/OpenTimelineIO-0.15.0.dev1.tar.gz)Show sdist diff