Use duration() as a virtual function #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
darbyjohnston
force-pushed
the
virtual_duration
branch
from
dc87311
to
b5652d2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 80.08% 80.10% +0.01%
==========================================
Files 197 197
Lines 21695 21687 -8
Branches 4298 4295 -3
==========================================
- Hits 17375 17372 -3
+ Misses 2173 2170 -3
+ Partials 2147 2145 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
ltgm! This looks like some legacy that fell through the cracks. Thanks for the fix! |
meshula
approved these changes
Jan 11, 2023
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513
I noticed a helper function
_safe_duration()that was dynamically casting aComposablejust to call the functionduration(). This isn't necessary sinceduration()is a virtual function ofComposable. The function_safe_duration()could be removed and replaced with calls toduration().